Fix cid serde feature reference (#235)

* Fix cid serde feature * Add CI check for Forest binary
ChainSafe · Feb 20, 2020 · 1411572 · 1411572
1 parent b598ffc
commit 1411572
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/.github/workflows/ci-rust.yml b/.github/workflows/ci-rust.yml
@@ -88,6 +88,12 @@ jobs:
           command: clippy
           args: -- -D warnings
 
+      - name: Check forest binary
+        uses: actions-rs/cargo@v1
+        with:
+          command: check
+          args: -p forest
+
   publish_docs:
     if: github.event_name == 'push' && github.event.ref == 'refs/heads/master'
     name: Publish Documentation

diff --git a/blockchain/blocks/Cargo.toml b/blockchain/blocks/Cargo.toml
@@ -9,7 +9,7 @@ address = { package = "forest_address", path = "../../vm/address" }
 crypto = { path = "../../crypto" }
 message = { package = "forest_message", path = "../../vm/message" }
 clock = { path = "../../node/clock" }
-cid = { package = "forest_cid", path = "../../ipld/cid" }
+cid = { package = "forest_cid", path = "../../ipld/cid", features = ["serde_derive"] }
 derive_builder = "0.9"
 serde = { version = "1.0", features = ["derive"] }
 encoding = { package = "forest_encoding", path = "../../encoding" }

diff --git a/ipld/cid/src/lib.rs b/ipld/cid/src/lib.rs
@@ -57,7 +57,7 @@ impl Default for Cid {
     }
 }
 
-#[cfg(feature = "serde")]
+#[cfg(feature = "serde_derive")]
 impl ser::Serialize for Cid {
     fn serialize<S>(&self, s: S) -> Result<S::Ok, S::Error>
     where
@@ -74,7 +74,7 @@ impl ser::Serialize for Cid {
     }
 }
 
-#[cfg(feature = "serde")]
+#[cfg(feature = "serde_derive")]
 impl<'de> de::Deserialize<'de> for Cid {
     fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
     where