Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup Network Node Configuration #4

Closed
ansermino opened this issue Nov 16, 2019 · 4 comments
Closed

Setup Network Node Configuration #4

ansermino opened this issue Nov 16, 2019 · 4 comments
Assignees
@ec2
Labels
Node Priority: 4 - Low Limited impact and can be implemented at any time

Comments

@ansermino
Copy link
Member

ansermino commented Nov 16, 2019 •
edited
Loading

Trivially, the Network Node will require some sort of config. This will likely contain: host, port, protocol prefix, identity key (or path to), and others.

This might be an opportunity to consider how we propagate config options from the CLI.
@ansermino ansermino mentioned this issue Nov 16, 2019
Closed
@ansermino ansermino added the Node label Nov 16, 2019
@amerameen amerameen assigned ec2 and unassigned ec2 Nov 18, 2019
@amerameen amerameen added the Priority: 4 - Low Limited impact and can be implemented at any time label Nov 18, 2019
@GregTheGreek
Copy link
Member

@ec2 Are you on this?

@ec2
Copy link
Member

ec2 commented Nov 20, 2019

Not yet.

@ec2 ec2 mentioned this issue Dec 2, 2019
Merged
4 tasks
@GregTheGreek
Copy link
Member

Once #54 you can do this via a config file

@GregTheGreek
Copy link
Member

Actually thats a lie, I need to PR in one more thing

@ec2 ec2 closed this as completed Dec 3, 2019
vmx pushed a commit to dignifiedquire/forest that referenced this issue Mar 19, 2020
@laser
feat(key snapshot by prover id + sector size) (ChainSafe#4)
3d10134 
* feat(key snapshot by prover id + sector size)

* feat(don't be a memory hog)

- don't copy memory from SectorBuilderState to StateSnapshot
- don't use a StateSnapshot type at all
- pass references, not owned (cloned) values to snapshotting stuff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ec2 ec2

Labels
Node Priority: 4 - Low Limited impact and can be implemented at any time
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@amerameen @ec2 @ansermino @GregTheGreek