Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add messages received over gossipsub to the message pool #763

Closed
2 tasks
amerameen opened this issue Oct 19, 2020 · 0 comments · Fixed by #797
Closed
2 tasks

Add messages received over gossipsub to the message pool #763

amerameen opened this issue Oct 19, 2020 · 0 comments · Fixed by #797
Labels
Node Priority: 3 - Medium Nice-to-have, does not impede core functionality

Comments

@amerameen
Copy link
Contributor

Currently, we receive messages over pubsub, but they are discarded.

Acceptance Criteria

  • Valid messages received over pubsub are added to the message pool.

Steps

  • Deserialize messages received over pubsub
  • Add the message to the messagepool (messagepool.add). This will implicitly do the necessary message validations.

Notes

@amerameen amerameen added Node Priority: 3 - Medium Nice-to-have, does not impede core functionality labels Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Node Priority: 3 - Medium Nice-to-have, does not impede core functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant