add msgs to msg pool #797
add msgs to msg pool #797
Conversation
dutterbutter
requested review from
ansermino,
austinabell and
ec2
as code owners
node/forest_libp2p/src/service.rs
Outdated
| @@ -95,9 +95,10 @@ pub enum NetworkMessage { | |||
| }, | |||
| } | |||
| /// The Libp2pService listens to events from the Libp2p swarm. | |||
| pub struct Libp2pService<DB: BlockStore> { | |||
| pub struct Libp2pService<DB: BlockStore, T: 'static> { | |||
There was a problem hiding this comment.
There isn't really a reason to constrain the generics on the struct, should just be constrained on the impl. You can remove the 'static constraint on the MessagePool struct, there was no reason for that to be there.
| pub struct Libp2pService<DB: BlockStore, T: 'static> { | |
| pub struct Libp2pService<DB, T> { |
| emit_event(&self.network_sender_out, NetworkEvent::PubsubMessage{ | ||
| source, | ||
| message: PubsubMessage::Message(m), | ||
| message: PubsubMessage::Message(m.clone()), | ||
| }).await; | ||
| // add message to message pool | ||
| if let Err(e) = self.mpool.add(m).await { | ||
| warn!("Gossip Message failed to be added to Message pool"); | ||
| } |
There was a problem hiding this comment.
Just noting here that it's not ideal to clone all messages because it's only needed inside mempool and not used from the emitted event, but can come in a following PR
There was a problem hiding this comment.
That's true. I don think anywhere else uses will listen on the channel for a message. I can make a PR for that
| emit_event(&self.network_sender_out, NetworkEvent::PubsubMessage{ | ||
| source, | ||
| message: PubsubMessage::Message(m), | ||
| message: PubsubMessage::Message(m.clone()), | ||
| }).await; | ||
| // add message to message pool | ||
| if let Err(e) = self.mpool.add(m).await { | ||
| warn!("Gossip Message failed to be added to Message pool"); | ||
| } |
There was a problem hiding this comment.
That's true. I don think anywhere else uses will listen on the channel for a message. I can make a PR for that
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #763
Other information and links