Update StateTree and implement cache #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
ansermino,
dutterbutter,
ec2 and
GregTheGreek
ansermino
approved these changes
Dec 16, 2019
dutterbutter
approved these changes
Dec 16, 2019
ec2
approved these changes
Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: To give more detail, this HamtStateTree struct will be able to used by us as an interim solution until the hamt is built out. The caching part will stay the way it is now after getting and setting an acotor with the hamt is built out though.
How it works is for getting if the actor exists in the cache, it will not query the hamt for the actor, but if not then it will query the hamt and then add it to the cache. For setting, if the cache contains the actor state that is trying to be set it will exit early (why the nested
Ok(())) and if not then the cache and hamt will be updated