[Audit fixes] FOR-02: Inconsistent Deserialization of Address ID #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptoquick
requested review from
connormullett,
creativcoder and
ec2
as code owners
ec2
reviewed
Jun 10, 2021
vm/address/src/lib.rs
Outdated
| if to_leb_bytes(id)? == bz { | ||
| Ok(id) | ||
| } else { | ||
| error!( |
There was a problem hiding this comment.
Probably makes sense to have this be part of the InvalidAddressIDPayload variant instead of printing it out
There was a problem hiding this comment.
Like, maybe using a tuple in the enum variant to capture the id?
There was a problem hiding this comment.
Take a look at these changes. Is this what you meant?
2e5f084
cryptoquick
changed the title
ec2
approved these changes
Jun 14, 2021
| @@ -13,6 +13,7 @@ num-derive = "0.3.0" | |||
| data-encoding = "2.1.2" | |||
| data-encoding-macro = "0.1.7" | |||
| leb128 = "0.2.1" | |||
| log = "0.4.8" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #1134
Other information and links
from_leb_128is too permissive of how leb128 bytes are deserialized, resulting in inconsistent behavior from how Lotus deserializes bytes. Lotus throws an error if there byte encodings are inconsistent.