Update Runtime to Support V5 Actors #1173
Conversation
ec2
requested review from
connormullett,
creativcoder and
cryptoquick
as code owners
|
This still has todos and failing tests and linter. Is this RFR? |
|
@ec2 It looks good in my localhost. I merge this branch to my dev branch and now It can sync the whole latest actorv5 interopnet network:) |
| let step = self | ||
| .verify_aggregate_seal_steps | ||
| .get(&proof_type) | ||
| .expect("There is an implementation error where proof type does not exist in table"); |
There was a problem hiding this comment.
Same suggestion here as before. A HashMap is lacking the knowledge that there is a price for each variant of proof type.
| &seeds, | ||
| inp, | ||
| )? { | ||
| Err("Invalid Aggregate Seal proof".into()) |
There was a problem hiding this comment.
Upsetting that this doesn't use a custom error type. Would it be worth it to create a ticket to define the error types here? Do you anticipate any complications will come up?
There was a problem hiding this comment.
I dont see why its useful or important here. These methods are generally used in actors. And the way the error is handled is irrespective of what error happens here anyways. I think a refactor of error handling in this might mess up with error propagation in actors.
Summary of changes
Changes introduced in this pull request:
verify_aggregate_sealsandbase_fee.TODO:
networkscrate to set Hyperdrive height (currently using placeholderReference issue to close (if applicable)
Closes
Other information and links