Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference files with PathBuf instead of Strings #1200

Merged
merged 4 commits into from
Aug 3, 2021
Merged

Reference files with PathBuf instead of Strings #1200

merged 4 commits into from
Aug 3, 2021

Conversation

leviathanbeak
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • switched to PathBuf instead of &str at places where Files and Folders are referenced
  • refactored few places for more idiomatic use of PathBufs

Reference issue to close (if applicable)
Closes #1158

@leviathanbeak leviathanbeak requested a review from a user July 28, 2021 16:08
cryptoquick
cryptoquick approved these changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@cryptoquick cryptoquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

cryptoquick
cryptoquick suggested changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@cryptoquick cryptoquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, one thing. Looks like this broke the linter. It made some good points. Can you take a look at the following issues?
https://app.circleci.com/pipelines/github/ChainSafe/forest/4930/workflows/c2328c6f-b6ed-43bf-afca-65ffd218ed4d/jobs/20505/parallel-runs/0/steps/0-111

@leviathanbeak
Copy link
Contributor Author

leviathanbeak commented Jul 29, 2021 •
edited
Loading

@cryptoquick thanks for the review, and thank you clippy for suggestions, updated it

cryptoquick
cryptoquick approved these changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@cryptoquick cryptoquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I'm good with cleanup as long as Clippy abides. I've found its insights really helpful.

connormullett
connormullett approved these changes Aug 2, 2021
View reviewed changes
Copy link
Contributor

@connormullett connormullett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution

@cryptoquick cryptoquick merged commit 7d5b333 into ChainSafe:main Aug 3, 2021
@cryptoquick
Copy link
Contributor

@leviathanbeak Thanks again for your contributions. Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connormullett connormullett connormullett approved these changes

@cryptoquick cryptoquick cryptoquick approved these changes

@creativcoder creativcoder Awaiting requested review from creativcoder

@ec2 ec2 Awaiting requested review from ec2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor String formatting used to reference Files using Path builders
3 participants
@leviathanbeak @cryptoquick @connormullett