Mpool CLI Commands

[connormullett]

Summary of changes
Changes introduced in this pull request:

• Adds MemPool commands stat and pending

Reference issue to close (if applicable)

Closes
#568

Other information and links

Note: To test mpool stat, a fully synced node is required or else it will fail.

[ec2]

This shouldn't build. There are merge conflicts.

[cryptoquick]

@connormullett Is this RFR now? be sure to merge main, btw

[connormullett]

@connormullett Is this RFR now? be sure to merge main, btw

Yup! Thanks for the reminder

[q9f]

./forest/src/cli/mpool_cmd.rs was missing header
./node/rpc-client/src/mpool_ops.rs was missing header

[q9f]

Did you discuss the usage of .unwarp() yet? I would prefer if we could reduce usage or at least relace them with something like .expect("Connor is certain this cannot fail ;-)")...

[q9f]

https://learning-rust.github.io/docs/e4.unwrap_and_expect.html#expect

[connormullett]

That's a good point, I haven't looked at this in a while so I don't remember which ones are infallible. Just going to handle the errors with graceful exits using cli_error_and_die

[connormullett]

Nevermind, I remembered something important. handle_rpc_error will exit and wrap an error from the rpc-api, such that when it is unwrapped it will be verbose as it is the error coming from the API wrapped in a JsonRpcError type

[q9f]

you can skip collecting the filter and check directly is_none() afaiu...

diff --git a/forest/src/cli/mpool_cmd.rs b/forest/src/cli/mpool_cmd.rs
index 2bbaaeda..2c4a4c69 100644
--- a/forest/src/cli/mpool_cmd.rs
+++ b/forest/src/cli/mpool_cmd.rs
@@ -106,12 +106,12 @@ impl MpoolCommands {
 
                     for message in &messages {
                         if !addresses.is_empty() {
-                            let filter: Vec<&Address> = addresses
+                            if addresses
                                 .iter()
                                 .filter(|&addr| addr == &message.message().from)
-                                .collect();
-
-                            if filter.is_empty() {
+                                .next()
+                                .is_none()
+                            {
                                 continue;
                             }
                         }