rust: default to stable toolchain instead of pinned version #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
q9f
requested review from
connormullett,
creativcoder and
ec2
as code owners
ec2
approved these changes
Sep 28, 2021
|
This needs more work, I'll do it tomorrow. |
q9f
commented
Sep 30, 2021
| @@ -241,7 +241,7 @@ jobs: | |||
| command: make license | |||
| - run: | |||
| name: cargo clippy | |||
| command: cargo clippy -- -D warnings -A clippy::upper_case_acronyms | |||
| command: cargo clippy -- -D warnings -A clippy::upper_case_acronyms -A clippy::needless_collect -A clippy::enum_variant_names -A clippy::needless_borrow | |||
There was a problem hiding this comment.
Look at this @ec2 - this makes clippy pass on stable and instead of fixing these warnings in a single PR, I would like to remove these warnings in subsequent PRs, so you can better review the changes, and if needed, easier revert in case something goes south.
|
This should be safe to merge now once CI is green. I will fix these warnings in separate pull requests. |
This was referenced Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
.circleci/config.ymlmsrv rust versionstablerust-toolchaindefault rust versionstableDockerfileuses1-busterrust imageDockerfile-ciuses1-busterrust imageOther information and links
The rust compiler release cycle is a moving target, and we should at least support the latest stable.
Subsequently, we can set up pipelines for beta, to be alerted about changes coming downstream.