-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Naive DB + Rocksdb implemenation #125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:D would be nice to have an in memory db for testing purposes, so I will open an issue to add this after (I can do this as I know how it can be done, but could leave if someone else wants to do)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meant to approve before, but lgtm once #136 comes in to fix the CI
Edit: Review still valid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
License. Otherwise lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
REMEMBER LICENSE
@GregTheGreek I think we should reference the |
What do you mean? |
The |
seperate pr ? |
I will leave it up to you...it would be a small addition though. |
Usage of it in this, especially since I am making changes on this in another PR, probably best to leave as is. I can add it in the one where I make changes to this (#132) |
This pr introduces a naive implementation of the database traits (read & write), and an implementation of rocksdb. Something to note about database implementations in rust is that they're built with lifetimes, thus they will always close, there is no need to gracefully shut them down.
Discussion points:
DatabaseService
trait is currently commented out since I ran into sizing issues returnSelf
open to discussions on how to solve that. The implementation hasOpen()
leveldb
showed that its fairly unmaintained and using old Rust idioms.RocksDb::read
orRocksDb::bulk_read
Closes #110