networks: Show an informative error message if the selected feature set is invalid. #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemmih
requested review from
connormullett,
ec2,
elmattic and
noot
as code owners
noot
reviewed
Jan 13, 2022
| @@ -19,7 +28,6 @@ pub use self::mainnet::*; | |||
| mod mainnet; | |||
| #[cfg(feature = "conformace")] | |||
| pub use self::mainnet::*; | |||
| pub use crate::mainnet::*; | |||
There was a problem hiding this comment.
I think this might be breaking the test vectors: https://github.com/ChainSafe/forest/runs/4806953786?check_suite_focus=true
|
Yeah, the situation was a bit more complicated then I thought. Old behavior: New behavior: One and only one network must be specified. If this isn't the case then an error will be raised. |
lemmih
added
Priority: 4 - Low
noot
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
networkscrate, emit an informative error message if none of the required feature flags are selected.Reference issue to close (if applicable)
Closes nothing.
Other information and links
This improves the error message if one tries to build
networkswithout any feature flags set.