introduce serde_generic_array #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Tianyi, is this ready for review? |
clearloop
requested review from
ec2,
noot,
connormullett,
elmattic,
lemmih and
LesnyRumcajs
as code owners
yeah, I'm thinking of should I provide some more tests for |
Yes, I would appreciate that 🙏🏼 |
LesnyRumcajs
requested changes
Feb 18, 2022
LesnyRumcajs
approved these changes
Feb 18, 2022
lemmih
approved these changes
Mar 4, 2022
lemmih
added a commit
that referenced
this pull request
Mar 4, 2022
…)" This reverts commit 1062469.
This was referenced Mar 4, 2022
lemmih
added a commit
that referenced
this pull request
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
serde_byte_arrayserde_generic_arraycheck_generic_array_length!Closes #1334
Other information and links