Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exposed more rocksdb options, increased max files #1481

Merged
merged 2 commits into from
Mar 18, 2022

Conversation

LesnyRumcajs
Copy link
Member

Summary of changes
Changes introduced in this pull request:

  • Expose more options for RocksDB,
  • Moved configuration to a separate file,
  • Increased the default number of open files from 200 to 1000 (it made snapshot import 50% faster, from ~1800 to 900 seconds). I tinkered with other settings but didn't see any spectacular improvement. I left some options exposed if anyone wants to tinker on their own.
  • defaulted compression to lz4

Reference issue to close (if applicable)

Closes #1473

Other information and links

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #1481 (1299a39) into main (d52d4f7) will increase coverage by 0.07%.
The diff coverage is 81.25%.

@@            Coverage Diff             @@
##             main    #1481      +/-   ##
==========================================
+ Coverage   44.16%   44.24%   +0.07%     
==========================================
  Files         322      323       +1     
  Lines       28482    28537      +55     
==========================================
+ Hits        12579    12625      +46     
- Misses      15903    15912       +9     
Impacted Files Coverage Δ
forest/src/cli/config.rs 0.00% <0.00%> (ø)
forest/src/daemon.rs 6.29% <0.00%> (-0.21%) ⬇️
node/db/src/lib.rs 100.00% <ø> (ø)
node/db/src/rocks.rs 87.50% <66.66%> (-8.66%) ⬇️
node/db/src/rocks_config.rs 100.00% <100.00%> (ø)
node/db/tests/db_utils/mod.rs 100.00% <100.00%> (ø)
blockchain/message_pool/src/msg_chain.rs 80.24% <0.00%> (-0.41%) ⬇️
vm/actor/src/builtin/miner/mod.rs 33.49% <0.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d52d4f7...1299a39. Read the comment docs.

@LesnyRumcajs LesnyRumcajs merged commit 41e13c9 into main Mar 18, 2022
@LesnyRumcajs LesnyRumcajs deleted the rocks-db-fine-tune branch March 18, 2022 10:30
LesnyRumcajs added a commit that referenced this pull request Mar 18, 2022
* exposed more rocksdb options, increased max files

* default to lz4 compression
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a configuration file for RockDB options.
3 participants