-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: patch yanked funty@1.2.0 with git commit #2210
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanabi1224
requested review from
elmattic,
lemmih,
LesnyRumcajs,
jdjaustin,
tyshko5,
creativcoder and
sudo-shashank
as code owners
November 16, 2022 10:14
Related issue: ferrilab/funty#7 |
@@ -40,6 +40,10 @@ members = [ | |||
] | |||
resolver = "2" | |||
|
|||
[patch.crates-io] | |||
# temporary solution to funty@1.2.0 being yanked, we should propose bitvec upgrade to upstream filecoin crates | |||
funty = { git = "https://github.com/bitvecto-rs/funty/", rev = "7ef0d890fbcd8b3def1635ac1a877fc298488446" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be good to add: tracking issue: https://github.com/bitvecto-rs/funty/issues/7
here for future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
creativcoder
approved these changes
Nov 16, 2022
lemmih
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
cargo update
command by patching yanked funty@1.2.0We currently get below errors when running
cargo update
, which blocks PRs that have conflicts inCargo.lock
Reference issue to close (if applicable)
Closes
Other information and links