fix Grafana on MacOS #2281
Merged
fix Grafana on MacOS #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When this is RFR, I can test it and review it. |
LesnyRumcajs
force-pushed
the
fix-grafana-macos
branch
from
bf7446e
to
c14a19c
Compare
LesnyRumcajs
requested review from
elmattic,
lemmih,
jdjaustin,
tyshko5,
hanabi1224,
creativcoder and
sudo-shashank
as code owners
|
@elmattic Feel free to test it on your end, be sure to recompile Forest to get it to listen on all interfaces for the metrics endpoint. |
Thanks for looking into this and reporting it! |
lemmih
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #2288
Other information and links
The issue stems from the fact that MacOS uses a thin VM for running docker. This doesn't work well with
hostnetwork, and the ports should be exposed explicitly (which is not possible withhostnetwork).A way out of this is using
host.docker.internal... which unfortunately exists only in Docker for MacOS (and probably in Docker for Windows). The way out of this is using a recently (2021) addedhost-gateway, see more docker/for-linux#264 (comment).Tested on MacOS Ventura 13.01 and Linux Fedora Workstation 36.