Refactor SyncManager to have ownership over tipsets #238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Don't be worried about the clone, it only creates a new pointer to the heap allocated tipset and increments the reference count. Also don't need to use the non-associative
Rc::clone(&other)
in my usages here because the type in enforced by the function usage, but be careful when cloning a tipset into the sync manager not to create a duplicate of it.Reference issue to close (if applicable)
Closes
Other information and links