Implement sync fork #248
Merged
Implement sync fork #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added sync fork method * Updated sync_headers_reverse to include forked tipsets
dutterbutter
requested review from
ansermino,
austinabell and
ec2
as code owners
austinabell
suggested changes
Mar 3, 2020
Comment on lines
+472
to
+476
| let tips: Vec<Tipset> = self | ||
| .network | ||
| .blocksync_headers(peer_id.clone(), head.parents(), FORK_LENGTH_THRESHOLD) | ||
| .await | ||
| .map_err(|_| Error::Other("Could not retrieve tipset".to_string()))?; |
There was a problem hiding this comment.
the problem I have with this is that if this one request to the one peer fails, this will exit the execution of the node. The way the sync function is called and handled is likely to change, but I don't think any network error should automatically fail the sync
austinabell
suggested changes
Mar 4, 2020
ec2
approved these changes
Mar 4, 2020
austinabell
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes N/A
Other information and links