Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cargo warnings from workspace default features not set #2529

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Feb 9, 2023

Summary of changes

Changes introduced in this pull request:

  • fix the warnings generated for cargo build and others after the toolchain bump.

When specifying a workspace dependency it is not obvious, and rather surprising that, not specifying default-features = false in the workspace dependency, means that any default-features = false is ignored in any member crate.

This I assume is because the features of workspace dependencies are additive, and by not specifying default-features = false, the default features are automatically and always enabled.

rust-lang/cargo#11329 (comment)

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@LesnyRumcajs LesnyRumcajs enabled auto-merge (squash) February 9, 2023 08:53
@hanabi1224
Copy link
Contributor

Not sure if it's worth the effort to add the check to the ruby script

@LesnyRumcajs
Copy link
Member Author

Not sure if it's worth the effort to add the check to the ruby script

I don't think so. The warning implies that it may become a hard error in the future, plus everyone compiling Forest will immediately see it anyway.

@LesnyRumcajs LesnyRumcajs merged commit 558796a into main Feb 9, 2023
@LesnyRumcajs LesnyRumcajs deleted the fix-cargo-warnings-default-features branch February 9, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants