Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State migrations nv18 #2666

Merged
merged 18 commits into from
Apr 14, 2023
Merged

State migrations nv18 #2666

merged 18 commits into from
Apr 14, 2023

Conversation

LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Mar 14, 2023 •
edited
Loading

Summary of changes

Changes introduced in this pull request:

  • resurrected and revamped the state migrations,
  • added NV18 migration support,
  • removed the legacy NV12 migration for now,
  • bundle download on startup if migration available,

Reference issue to close (if applicable)

Closes #1454

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@LesnyRumcajs LesnyRumcajs force-pushed the state-migration-nv18 branch 2 times, most recently from 31761d5 to 76569ad Compare March 22, 2023 18:08
@CLAassistant
Copy link

CLAassistant commented Mar 23, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@LesnyRumcajs LesnyRumcajs force-pushed the state-migration-nv18 branch 5 times, most recently from 4c3b1d7 to 31eadb7 Compare April 4, 2023 13:57
@LesnyRumcajs LesnyRumcajs force-pushed the state-migration-nv18 branch from 31eadb7 to 3a7084c Compare April 4, 2023 16:11
@LesnyRumcajs LesnyRumcajs force-pushed the state-migration-nv18 branch from cc7716b to 7c78431 Compare April 6, 2023 16:32
@LesnyRumcajs LesnyRumcajs force-pushed the state-migration-nv18 branch from 5d2ea30 to 2196571 Compare April 13, 2023 18:35
@LesnyRumcajs LesnyRumcajs force-pushed the state-migration-nv18 branch from 2196571 to 20db14d Compare April 13, 2023 18:38
@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review April 14, 2023 08:26
@LesnyRumcajs LesnyRumcajs changed the title [wip] state migrations nv18 State migrations nv18 Apr 14, 2023
lemmih
lemmih reviewed Apr 14, 2023
View reviewed changes
networks/src/calibnet/mod.rs Show resolved Hide resolved
.config/forest.dic Show resolved Hide resolved
@LesnyRumcajs LesnyRumcajs force-pushed the state-migration-nv18 branch from 249772c to 0c0be3b Compare April 14, 2023 10:07
elmattic
elmattic approved these changes Apr 14, 2023
View reviewed changes
forest/daemon/src/bundle/mod.rs Outdated Show resolved Hide resolved
forest/daemon/src/daemon.rs Show resolved Hide resolved
vm/state_migration/src/common/mod.rs Outdated Show resolved Hide resolved
vm/state_migration/src/common/mod.rs Show resolved Hide resolved
@LesnyRumcajs LesnyRumcajs merged commit 8d4973c into main Apr 14, 2023
@LesnyRumcajs LesnyRumcajs deleted the state-migration-nv18 branch April 14, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemmih lemmih lemmih left review comments

@elmattic elmattic elmattic approved these changes

@hanabi1224 hanabi1224 hanabi1224 approved these changes

@jdjaustin jdjaustin Awaiting requested review from jdjaustin

@creativcoder creativcoder Awaiting requested review from creativcoder

@sudo-shashank sudo-shashank Awaiting requested review from sudo-shashank

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-design State Migration
5 participants
@LesnyRumcajs @CLAassistant @lemmih @hanabi1224 @elmattic