Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive mpool commands #2740

Closed
wants to merge 92 commits into from
Closed

Revive mpool commands #2740

wants to merge 92 commits into from

Conversation

elmattic
Copy link
Contributor

@elmattic elmattic commented Mar 31, 2023

Summary of changes

Changes introduced in this pull request:

  • Fix sticking mpool messages in case of "single tipset" errors
  • Add limits for each actors to prevent unwanted spam
  • Add back mpool pending with same Lotus flags
  • Add back mpool stat

You can test them using shell command (most of the time mpool is empty on calibnet):

$ repeat 1000 ./target/release/forest-cli mpool pending && echo "---" && sleep 1
---
---
---
---
---
---
{
  "Message": {
    "Version": 0,
    "To": "t01491",
    "From": "t3sg27lp6xgz3fb7db7t4x4lhmsf3dgu73mj5sodkshh64ftr6dzkrfxrowroon2cr2f3vkumsi4schkpfyvea",
    "Nonce": 14704,
    "Value": "0",
    "GasLimit": 31073678,
    "GasFeeCap": "100507",
    "GasPremium": "99453",
    "Method": 6,
    "Params": "iggZG3DYKlgpAAGC4gOB6AIgRRHJtEnHDx51h/M46ebVUjTD1kowbg+8uWOSrQnQYWwaAAaPXIAaAB45DvQAAAA=",
    "CID": {
      "/": "bafy2bzaceacz2f5k5pcjhzvodhpgin2phycgk2magezaxxp7wcqrjvobbtj5w"
    }
  },
  "Signature": {
    "Type": 2,
    "Data": "hcBY3OATkjMBRly96aViP2CR0R68dqnmlB1k6g2C2EXfe7+AsCN7bF4+M5bA6SecCsP2Fx+NwYkpGBi1CFGon5U9bqilMIiXxuK0mIrNO0d6UocCBGi/IVZwW2K4hT9N"
  },
  "CID": {
    "/": "bafy2bzaceacz2f5k5pcjhzvodhpgin2phycgk2magezaxxp7wcqrjvobbtj5w"
  }
}
$ ./target/release/forest-cli mpool stat
t13phw6spj7uode7n5zm4tr4v5jp3rh2ff3byrcxq: Nonce past: 1, cur: 0, future: 0; FeeCap cur: 0, min-60: 0, gasLimit: 63370305
t1u2htzdz77nhhrial6cfdlekcou5cbhtmtbrzoaq: Nonce past: 1, cur: 0, future: 0; FeeCap cur: 0, min-60: 0, gasLimit: 42586957
t410fxkwkdni3fjjmweyaarxq2mipbd54p4e5vzaeygq: Nonce past: 1, cur: 0, future: 0; FeeCap cur: 0, min-60: 0, gasLimit: 7803847
-----
total: Nonce past: 3, cur: 0, future: 0; FeeCap cur: 0, min-60: 0, gasLimit: 113761109

Reference issue to close (if applicable)

Closes #2728, #2761

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works
    (if possible),
  • I have made sure the
    CHANGELOG is
    up-to-date. All user-facing changes should be reflected in this document.

@elmattic elmattic marked this pull request as ready for review April 13, 2023 10:21
@LesnyRumcajs
Copy link
Member

@elmattic is this ready for review? The Change checklist indicates it's not but the green Open suggests it is. :)

@elmattic elmattic marked this pull request as draft April 18, 2023 08:35
@elmattic
Copy link
Contributor Author

Note: This PR will be abandoned and replaced by smaller PRs more easy to review (first is #3020).

@elmattic
Copy link
Contributor Author

elmattic commented Jul 3, 2023

Closing it for aforementioned reason.

@elmattic elmattic closed this Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revive cli mpool commands
2 participants