Init actor implementation #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
ansermino,
dutterbutter and
ec2
as code owners
ec2
approved these changes
Mar 16, 2020
dutterbutter
approved these changes
Mar 16, 2020
vm/actor/src/builtin/init/state.rs
Outdated
| None => return Err(HamtError::Custom("address not found")), | ||
| }; | ||
|
|
||
| Ok(Address::new_id(actor_id.0).unwrap()) |
There was a problem hiding this comment.
Any particular reason for the unwrap() usage here?
There was a problem hiding this comment.
because that can't realistically fail and I didn't want to change the error type, but I'll change
vm/actor/src/builtin/init/state.rs
Outdated
|
|
||
| let actor_id: ActorID = match map.get(&addr.hash_key())? { | ||
| Some(id) => id, | ||
| None => return Err(HamtError::Custom("address not found")), |
There was a problem hiding this comment.
Small nit: are we capitalizing error messages? Whichever it is I think we should keep consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Other information and links