Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: compute correct tipset CID #2996

Merged
merged 5 commits into from
Jun 16, 2023
Merged

fix: compute correct tipset CID #2996

merged 5 commits into from
Jun 16, 2023

Conversation

lemmih
Copy link
Contributor

@lemmih lemmih commented Jun 15, 2023 •
edited
Loading

Summary of changes

Changes introduced in this pull request:

  • An FVM extern function was supposed to turn the hash of a tipset's keys rather than the state-root.
  • This bug has been around since NV18 (we're now at NV20) but it just hasn't mattered until now.
  • I've verified that epoch 632281 and 643586 pass on calibnet.
  • I've verified that epoch 2942404 and 2949733 pass on mainnet.

Reference issue to close (if applicable)

Closes #2958

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@lemmih lemmih changed the title use the correct tipset key cid fix: compute correct tipset CIDs Jun 15, 2023
@lemmih lemmih changed the title fix: compute correct tipset CIDs fix: compute correct tipset CID Jun 15, 2023
@lemmih lemmih marked this pull request as ready for review June 15, 2023 23:14
@lemmih lemmih merged commit e1abede into main Jun 16, 2023
@lemmih lemmih deleted the lemmih/fix-state-root-mismatch-invoke-contract branch June 16, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanabi1224 hanabi1224 hanabi1224 approved these changes

@ruseinov ruseinov ruseinov approved these changes

@elmattic elmattic Awaiting requested review from elmattic

@LesnyRumcajs LesnyRumcajs Awaiting requested review from LesnyRumcajs

@jdjaustin jdjaustin Awaiting requested review from jdjaustin

@creativcoder creativcoder Awaiting requested review from creativcoder

@sudo-shashank sudo-shashank Awaiting requested review from sudo-shashank

@aatifsyed aatifsyed Awaiting requested review from aatifsyed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

State root mismatches (both calibnet and mainnet)
3 participants
@lemmih @ruseinov @hanabi1224