Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: separate ChainStore and ChainIndex #3216

Merged
merged 4 commits into from
Jul 18, 2023
Merged

Conversation

lemmih
Copy link
Contributor

@lemmih lemmih commented Jul 17, 2023

Summary of changes

Changes introduced in this pull request:

  • Move tipset_from_keys from ChainStore into ChainIndex. This is where it belongs, conceptually.
  • I'll rewrite all of ChainIndex in a follow-up PR.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@lemmih lemmih marked this pull request as ready for review July 18, 2023 04:29
@lemmih lemmih requested a review from a team as a code owner July 18, 2023 04:29
@lemmih lemmih requested review from hanabi1224 and jdjaustin and removed request for a team July 18, 2023 04:29
@lemmih lemmih enabled auto-merge July 18, 2023 04:35
@lemmih lemmih requested a review from sudo-shashank July 18, 2023 05:12
Copy link
Member

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be fantastic to take this opportunity to write some high-level doc in those modules on what they do, conceptually.

@lemmih
Copy link
Contributor Author

lemmih commented Jul 18, 2023

It'd be fantastic to take this opportunity to write some high-level doc in those modules on what they do, conceptually.

It's coming in a follow-up PR.

@lemmih lemmih added this pull request to the merge queue Jul 18, 2023
Merged via the queue into main with commit 28056d3 Jul 18, 2023
@lemmih lemmih deleted the lemmih/refactor-chain-store branch July 18, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants