Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
thiserror
crate (https://github.com/dtolnay/thiserror) which makes it more extensible and clean/quick to useThere are still things I think could be improved, but I tried to keep these changes unopinionated without making any functional changes.
Only functional changes are two things I suspect to be bugs here if that doesn't resolve, the change(s) in
chain_store.rs
@dutterbutter can you confirm there isn't a specific reason it should not changeReference issue to close (if applicable)
Closes
#216
Other information and links