IPLD Selector framework with serialization #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
changed the title
ec2
approved these changes
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Since these changes will get very dense quick, going to split up PRing them in to make it easier to review. This handles the serialization and deserialization of selectors as well as some of the basic logic.
Second part of this will be the core execution of the selector, which is somewhat blocked on #390 (for testing convenience).
Issue for ref: #241 (go-ipld-prime is the only other impl of this, and one we have to match so can verify details against that and anything conceptual against the spec)
Reference issue to close (if applicable)
Closes
Other information and links