-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable rsa feature for libp2p #3996
Conversation
@@ -118,6 +118,7 @@ libp2p = { version = "0.53", default-features = false, features = [ | |||
'tokio', | |||
'macros', | |||
'serde', | |||
'rsa', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we explicitly enable all of secp256k1
, ecdsa
, rsa
and ed25519
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add them. I'll ask around to ensure it's ultimately what we need.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per the code, the list should be exhaustive
#[derive(Debug, Clone)]
#[allow(clippy::large_enum_variant)]
enum KeyPairInner {
/// An Ed25519 keypair.
#[cfg(feature = "ed25519")]
Ed25519(ed25519::Keypair),
/// An RSA keypair.
#[cfg(all(feature = "rsa", not(target_arch = "wasm32")))]
Rsa(rsa::Keypair),
/// A Secp256k1 keypair.
#[cfg(feature = "secp256k1")]
Secp256k1(secp256k1::Keypair),
/// An ECDSA keypair.
#[cfg(feature = "ecdsa")]
Ecdsa(ecdsa::Keypair),
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does enabling rsa
do?
To my understanding, it allows upgrading the connection to an encrypted one. |
aece806
to
2e06c63
Compare
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #3990
Other information and links
Change checklist