Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Address default implementation #422

Merged
merged 1 commit into from
May 18, 2020
Merged

Remove Address default implementation #422

merged 1 commit into from
May 18, 2020

Conversation

austinabell
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • Just for safety so it can't be misused this way
    • Could technically also be done for Cid, but the ergonomics of that is a way higher cost than this

Reference issue to close (if applicable)

Closes

Other information and links

@austinabell austinabell merged commit 187ca6c into master May 18, 2020
@austinabell austinabell deleted the austin/remaddrdef branch May 18, 2020 17:06
@rllola rllola mentioned this pull request May 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StaticallyTypedAnxiety StaticallyTypedAnxiety StaticallyTypedAnxiety approved these changes

@timvermeulen timvermeulen timvermeulen approved these changes

@ansermino ansermino Awaiting requested review from ansermino

@dutterbutter dutterbutter Awaiting requested review from dutterbutter

@ec2 ec2 Awaiting requested review from ec2

@flodesi flodesi Awaiting requested review from flodesi

@RajarupanSampanthan RajarupanSampanthan Awaiting requested review from RajarupanSampanthan

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@austinabell @timvermeulen @StaticallyTypedAnxiety