Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump rust toolchain version to 1.78.0 #4284

Merged
merged 1 commit into from
May 6, 2024
Merged

chore: bump rust toolchain version to 1.78.0 #4284

merged 1 commit into from
May 6, 2024

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented May 2, 2024 •
edited
Loading

Summary of changes

Changes introduced in this pull request:

  • bump rust toolchain version
  • fix clippy warnings

Reference issue to close (if applicable)

Closes

Other information and links

https://releases.rs/docs/1.78.0/

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 marked this pull request as ready for review May 2, 2024 23:48
@hanabi1224 hanabi1224 requested a review from a team as a code owner May 2, 2024 23:48
@hanabi1224 hanabi1224 requested review from elmattic and sudo-shashank and removed request for a team May 2, 2024 23:48
@LesnyRumcajs
Copy link
Member

What was the diagnostic from clippy that caused the changes?

@hanabi1224
Copy link
Contributor Author

@LesnyRumcajs deadcode

LesnyRumcajs
LesnyRumcajs approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised previous versions didn't catch this dead code.

@hanabi1224 hanabi1224 added this pull request to the merge queue May 6, 2024
Merged via the queue into main with commit 302d002 May 6, 2024
31 checks passed
@hanabi1224 hanabi1224 deleted the hm/rust-1.78.0 branch May 6, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LesnyRumcajs LesnyRumcajs LesnyRumcajs approved these changes

@elmattic elmattic elmattic approved these changes

@sudo-shashank sudo-shashank Awaiting requested review from sudo-shashank sudo-shashank is a code owner automatically assigned from ChainSafe/forest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hanabi1224 @LesnyRumcajs @elmattic