-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ApiHeadChange
type
#4357
Fix ApiHeadChange
type
#4357
Conversation
@alt-ivan could you please confirm that this change works for you? |
@LesnyRumcajs |
@LesnyRumcajs |
@elmattic |
@alt-ivan I've committed a fix to properly support several WS clients. Can you have a second look? I've tested the following scenario on my side (on both macOS and Ubuntu):
All three channel outputs look alike. Channel cancellation works properly. |
Awesome, thanks! I'll report back here as soon as I re-test everything |
Hi, I have re-tested and can confirm that everything works as expected. I apologize for the delay! |
No worries! Thanks for your help with the testing. |
Summary of changes
Changes introduced in this pull request:
ApiHeadChange
typeReference issue to close (if applicable)
Closes #4371, #4002
Other information and links
The endpoint code is only being manually tested at the moment. I've attached the script used and what the result files look like once you have run it (using
node index.js
).index.txt
forest.log
lotus.log
In the attached log files, we should have an exact match for notifications of the type
"current"
. We should have a match for notifications of type"apply"
whenVal.Cids
values are the same.Change checklist