-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rpc): Filecoin.EthEstimateGas #4496
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanabi1224
force-pushed
the
hm/EthEstimateGas
branch
from
July 10, 2024 07:18
6585926
to
a38f967
Compare
hanabi1224
force-pushed
the
hm/EthEstimateGas
branch
from
July 10, 2024 12:04
df428bf
to
a63f9cb
Compare
hanabi1224
requested review from
lemmih and
sudo-shashank
and removed request for
a team
July 18, 2024 03:54
hanabi1224
commented
Jul 18, 2024
} | ||
|
||
impl GasEstimateGasLimit { | ||
pub async fn estimate_call_with_gas<DB>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving free fn estimate_gas_limit
here and split it into estimate_call_with_gas
and estimate_gas_limit
lemmih
approved these changes
Jul 18, 2024
sudo-shashank
approved these changes
Jul 18, 2024
sudo-shashank
approved these changes
Jul 19, 2024
@sudo-shashank Please re-approve again. This PR constantly gets merge conflicts : ) |
lemmih
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Filecoin.EthEstimateGas
Filecoin.EthEstimateGas
#4554Filecoin.EthEstimateGas
result is inaccurate on an offline RPC server #4555Reference issue to close (if applicable)
Closes #4556
Other information and links
Change checklist