Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rpc) Implement Filecoin.EthMaxPriorityFeePerGas #4511

Merged
merged 5 commits into from
Jul 16, 2024
Merged

feat(rpc) Implement Filecoin.EthMaxPriorityFeePerGas #4511

merged 5 commits into from
Jul 16, 2024

Conversation

sudo-shashank
Copy link
Contributor

@sudo-shashank sudo-shashank commented Jul 11, 2024 •
edited
Loading

Summary of changes

Changes introduced in this pull request:

  • Implement Filecoin.EthMaxPriorityFeePerGas RPC method
  • API compare tests

Reference issue to close (if applicable)

Contributes to #4165

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@sudo-shashank sudo-shashank mentioned this pull request Jul 11, 2024
Closed
40 tasks
@sudo-shashank sudo-shashank marked this pull request as ready for review July 11, 2024 11:23
@sudo-shashank sudo-shashank requested a review from a team as a code owner July 11, 2024 11:23
@sudo-shashank sudo-shashank requested review from lemmih and elmattic and removed request for a team July 11, 2024 11:23
@LesnyRumcajs
Copy link
Member

@sudo-shashank Could you please add a changelog entry?

@sudo-shashank sudo-shashank force-pushed the shashank/Rpc-EthMaxPriorityFeePerGas branch from c2c3bf2 to abaeeb8 Compare July 16, 2024 05:22
@sudo-shashank
Copy link
Contributor Author

@sudo-shashank Could you please add a changelog entry?

updated

@sudo-shashank sudo-shashank added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit f681325 Jul 16, 2024
28 checks passed
@sudo-shashank sudo-shashank deleted the shashank/Rpc-EthMaxPriorityFeePerGas branch July 16, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aatifsyed aatifsyed aatifsyed approved these changes

@elmattic elmattic Awaiting requested review from elmattic elmattic is a code owner automatically assigned from ChainSafe/forest

@lemmih lemmih Awaiting requested review from lemmih

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sudo-shashank @LesnyRumcajs @lemmih @aatifsyed