Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): implement Filecoin.StateGetAllocationIdForPendingDeal #4512

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Jul 11, 2024

Summary of changes

Changes introduced in this pull request:

  • implement RPC method Filecoin.StateGetAllocationIdForPendingDeal
  • API compare tests
  • fix changelog entry position for Filecoin.StateMinerAllocated
     Running `target/quick/forest-tool api compare /home/me/fr/snapshots/calibnet/forest_snapshot_calibnet_2024-07-11_height_1777770.forest.car.zst --filter StateGetAllocationIdForPendingDeal`
| RPC Method                                       | Forest | Lotus |
|--------------------------------------------------|--------|-------|
| Filecoin.StateGetAllocationIdForPendingDeal (40) | Valid  | Valid |

Reference issue to close (if applicable)

Closes #4508

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 marked this pull request as ready for review July 11, 2024 10:44
@hanabi1224 hanabi1224 requested a review from a team as a code owner July 11, 2024 10:44
@hanabi1224 hanabi1224 requested review from lemmih and sudo-shashank and removed request for a team July 11, 2024 10:44
@hanabi1224 hanabi1224 enabled auto-merge July 11, 2024 11:20
@hanabi1224 hanabi1224 added this pull request to the merge queue Jul 11, 2024
Merged via the queue into main with commit 103f466 Jul 11, 2024
28 checks passed
@hanabi1224 hanabi1224 deleted the hm/StateGetAllocationIdForPendingDeal branch July 11, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StateGetAllocationIdForPendingDeal
3 participants