[Enhancement] Macros for State.GetAll* #4551
Conversation
ruseinov
requested review from
lemmih and
LesnyRumcajs
and removed request for
a team
src/shim/actors/verifreg/state.rs
Outdated
| }; | ||
| Ok(result) | ||
| } | ||
| } | ||
|
|
||
| #[macro_export] |
There was a problem hiding this comment.
Do we have to export these macros?
There was a problem hiding this comment.
If we don't - the macros have to be defined strictly above the code that uses them, which is inconvenient.
There was a problem hiding this comment.
this exports the macro as a public item at the root of the crate. Does pub(crate) use list_all_inner below the macro work? Else I think moving the definition to the top of the file is the right thing to do
src/shim/actors/verifreg/state.rs
Outdated
| }; | ||
| Ok(result) | ||
| } | ||
| } | ||
|
|
||
| #[macro_export] |
There was a problem hiding this comment.
this exports the macro as a public item at the root of the crate. Does pub(crate) use list_all_inner below the macro work? Else I think moving the definition to the top of the file is the right thing to do
Gotta |
Summary of changes
Changes introduced in this pull request:
VerifiedRegistryStateExtReference issue to close (if applicable)
Work on #4550
Other information and links
Change checklist