Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align StateMinerProvingDeadline with Lotus #4635

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

lemmih
Copy link
Contributor

@lemmih lemmih commented Aug 9, 2024

Summary of changes

Changes introduced in this pull request:

  • In Lotus, calling DeadlineInfo redirects to RecordedDeadlineInfo. For reasons I don't understand, there exists deadline_info() and recorded_deadline_info(). There may be more places where we call the wrong function.
  • This PR only fixes StateMinerProvingDeadline.

Reference issue to close (if applicable)

Closes #4630

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@lemmih lemmih marked this pull request as ready for review August 9, 2024 13:44
@lemmih lemmih requested a review from a team as a code owner August 9, 2024 13:44
@lemmih lemmih requested review from ruseinov and hanabi1224 and removed request for a team August 9, 2024 13:44
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Aug 9, 2024
Merged via the queue into main with commit ca45dd0 Aug 9, 2024
30 checks passed
@LesnyRumcajs LesnyRumcajs deleted the lemmih/fix-miner-proving-deadline branch August 9, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Filecoin.StateMinerProvingDeadline
3 participants