Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logs to EthTxReceipt #4988

Merged
merged 5 commits into from
Nov 22, 2024
Merged

Conversation

elmattic
Copy link
Contributor

@elmattic elmattic commented Nov 19, 2024

Summary of changes

Changes introduced in this pull request:

  • Fix the logs member in EthTxReceipt that was initialized with a default value.
  • Remove Filecoin.EthGetTransactionReceipt from the filter lists

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@elmattic elmattic marked this pull request as ready for review November 19, 2024 15:14
@elmattic elmattic requested a review from a team as a code owner November 19, 2024 15:14
@elmattic elmattic requested review from ruseinov and removed request for a team November 19, 2024 15:14
@elmattic elmattic added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit bb51791 Nov 22, 2024
40 checks passed
@elmattic elmattic deleted the elmattic/eth_get_transaction_receipt_logs branch November 22, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants