Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move fil_actor_interface to forest shim #5001

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Move fil_actor_interface to forest shim #5001

merged 3 commits into from
Dec 4, 2024

Conversation

sudo-shashank
Copy link
Contributor

@sudo-shashank sudo-shashank commented Nov 25, 2024 •
edited
Loading

Summary of changes

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes #4875

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@sudo-shashank sudo-shashank force-pushed the shashank/move-actor-interface branch from 08ae10f to adeb5ae Compare November 26, 2024 09:34
@sudo-shashank sudo-shashank marked this pull request as ready for review November 27, 2024 13:01
@sudo-shashank sudo-shashank requested review from a team as code owners November 27, 2024 13:01
hanabi1224
hanabi1224 reviewed Nov 27, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@sudo-shashank sudo-shashank marked this pull request as draft December 2, 2024 11:51
@sudo-shashank sudo-shashank force-pushed the shashank/move-actor-interface branch from 36dc8c5 to 6b65f13 Compare December 3, 2024 14:46
@sudo-shashank sudo-shashank force-pushed the shashank/move-actor-interface branch from 6b65f13 to 85dafbb Compare December 3, 2024 14:51
@sudo-shashank sudo-shashank marked this pull request as ready for review December 3, 2024 15:59
hanabi1224
hanabi1224 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@hanabi1224 hanabi1224 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (But did not review the copy & pasted fil-actor-interface code line by line)

@sudo-shashank
Copy link
Contributor Author

LGTM (But did not review the copy & pasted fil-actor-interface code line by line)

those were copied verbatimly from fil_actor_states repo

@LesnyRumcajs
Copy link
Member

@sudo-shashank is there a corresponding PR that removes this interface from fil-actor-states?

@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit 11d505e Dec 4, 2024
35 checks passed
@LesnyRumcajs LesnyRumcajs deleted the shashank/move-actor-interface branch December 4, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LesnyRumcajs LesnyRumcajs LesnyRumcajs approved these changes

@hanabi1224 hanabi1224 hanabi1224 approved these changes

@ruseinov ruseinov Awaiting requested review from ruseinov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move fil-actor-interface crate from fil-actor-states repo
4 participants
@sudo-shashank @LesnyRumcajs @ruseinov @hanabi1224