Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release: v0.23.2, no NV25 for calibnet #5079

Merged
merged 1 commit into from
Dec 13, 2024
Merged

release: v0.23.2, no NV25 for calibnet #5079

merged 1 commit into from
Dec 13, 2024

Conversation

LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Dec 13, 2024 •
edited
Loading

Summary of changes

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

LesnyRumcajs
LesnyRumcajs commented Dec 13, 2024
View reviewed changes
src/state_migration/mod.rs
@@ -64,7 +64,7 @@ where
(Height::Dragon, nv22::run_migration::<DB>),
(Height::DragonFix, nv22fix::run_migration::<DB>),
(Height::Waffle, nv23::run_migration::<DB>),
(Height::Teep, nv25::run_migration::<DB>),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, we should start doing again the regression tests for migrations!

@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review December 13, 2024 07:41
@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner December 13, 2024 07:41
@LesnyRumcajs LesnyRumcajs requested review from lemmih and sudo-shashank and removed request for a team December 13, 2024 07:41
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit f58b181 Dec 13, 2024
40 checks passed
@LesnyRumcajs LesnyRumcajs deleted the release-v0.23.2 branch December 13, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudo-shashank sudo-shashank sudo-shashank approved these changes

@hanabi1224 hanabi1224 hanabi1224 approved these changes

@lemmih lemmih Awaiting requested review from lemmih lemmih is a code owner automatically assigned from ChainSafe/forest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LesnyRumcajs @hanabi1224 @sudo-shashank