Add an async logger #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec2
requested review from
austinabell,
GregTheGreek,
ansermino and
dutterbutter
GregTheGreek
requested changes
Nov 29, 2019
ansermino
approved these changes
Nov 29, 2019
austinabell
reviewed
Nov 29, 2019
dutterbutter
approved these changes
Nov 29, 2019
austinabell
suggested changes
Nov 30, 2019
Co-Authored-By: Austin Abell <austinabell8@gmail.com>
Co-Authored-By: Austin Abell <austinabell8@gmail.com>
austinabell
approved these changes
Nov 30, 2019
GregTheGreek
approved these changes
Nov 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a logger. The choice of logger is
slog, as it has async logging capabilities. This allows us to log things without blocking by sending logs to another thread which writes to stdout.Closes: