Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Filecoin.EthTraceTransaction #5386

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

sudo-shashank
Copy link
Contributor

@sudo-shashank sudo-shashank commented Mar 7, 2025

Summary of changes

Changes introduced in this pull request:

  • Implement Filecoin.EthTraceTransaction and add test.
| RPC Method                       | Forest | Lotus |
|----------------------------------|--------|-------|
| Filecoin.EthTraceTransaction (6) | Valid  | Valid |

Reference issue to close (if applicable)

Closes #5330

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@sudo-shashank sudo-shashank marked this pull request as ready for review March 7, 2025 12:33
@sudo-shashank sudo-shashank requested a review from a team as a code owner March 7, 2025 12:33
@sudo-shashank sudo-shashank requested review from lemmih and LesnyRumcajs and removed request for a team March 7, 2025 12:33
Copy link
Member

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add an RPC snapshot test for this?

@sudo-shashank sudo-shashank marked this pull request as draft March 10, 2025 07:18
@sudo-shashank sudo-shashank requested a review from elmattic March 12, 2025 08:40
@sudo-shashank sudo-shashank marked this pull request as ready for review March 12, 2025 08:54
@sudo-shashank sudo-shashank enabled auto-merge March 12, 2025 08:54
@sudo-shashank sudo-shashank force-pushed the shashank/EthTraceTransaction branch from 2a6fbfb to 41ccd6d Compare March 12, 2025 12:52
@sudo-shashank sudo-shashank disabled auto-merge March 12, 2025 13:09
@sudo-shashank sudo-shashank force-pushed the shashank/EthTraceTransaction branch 2 times, most recently from 350c1da to 9cce06f Compare March 12, 2025 13:18
@sudo-shashank sudo-shashank force-pushed the shashank/EthTraceTransaction branch from 9cce06f to 7f8291a Compare March 12, 2025 13:19
@sudo-shashank sudo-shashank force-pushed the shashank/EthTraceTransaction branch from 7f8291a to 508216c Compare March 12, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Filecoin.EthTraceTransaction RPC method
4 participants