Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Runner for Message Signing Serialization Vectors #548

Merged
merged 12 commits into from
Jul 18, 2020
Merged

Test Runner for Message Signing Serialization Vectors #548

merged 12 commits into from
Jul 18, 2020

Conversation

flodesi
Copy link
Contributor

@flodesi flodesi commented Jul 16, 2020

Summary of changes
Changes introduced in this pull request:

  • Update Unsigned message serialization to account for null param values
  • Write unsigned message test for serialization vectors

Closes #339

@flodesi flodesi requested a review from austinabell July 16, 2020 20:03
@flodesi flodesi requested a review from austinabell July 17, 2020 02:44
@flodesi flodesi merged commit 53378a9 into main Jul 18, 2020
@flodesi flodesi deleted the jaden/message_signing_ser_test branch July 18, 2020 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinabell austinabell austinabell approved these changes

@ec2 ec2 ec2 approved these changes

@ansermino ansermino Awaiting requested review from ansermino

@dutterbutter dutterbutter Awaiting requested review from dutterbutter

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write test runner for Message signing serialization vectors
3 participants
@flodesi @ec2 @austinabell