-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #51 - Add basic makefile #57
Conversation
Have you taken a look at cargo-make? https://github.com/sagiegurari/cargo-make |
yeah it looks like a terrible UX ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add commands to do release and standard builds (could also add subcommands for each system binary we have and make build just builds all)?
A make clean
command would be nice as well as well as a run function (to either run the built binary or just to run with cargo run -p node
, thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would make more sense for clean
to be a separate command. If I run make build
I would not expect it to also do a clean. Maybe that's just me.
Might also be worth adding make test
.
and if you make those other tweaks, might be worth to just quickly update the README |
Co-Authored-By: Austin Abell <austinabell8@gmail.com>
New Features:
make lint
make build
make release
Notes:
make run
because that would mean passing in cli args to a Makefile which breaks the Makefile pattern