Update Drand to use HTTP with the new endpoint #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec2
requested review from
ansermino,
austinabell and
dutterbutter
as code owners
ec2
requested review from
RajarupanSampanthan,
flodesi,
StaticallyTypedAnxiety and
timvermeulen
austinabell
reviewed
Jul 30, 2020
| period: i32, | ||
| genesis_time: i32, | ||
| hash: String, | ||
| #[serde(rename = "groupHash")] |
There was a problem hiding this comment.
is this really the case that they camel case this but not public_key and genesis_time?
Edit: I don't see this field on the docs: https://drand.love/developer/http-api/#info are those out of date?
There was a problem hiding this comment.
I'm not sure whats up with the docs, but heres the endpoint if you wanna see for yourself. It threw me off as well lol https://pl-eu.testnet.drand.sh/info
There was a problem hiding this comment.
Well, that wasn't thought through very well hahaha
dutterbutter
approved these changes
Jul 30, 2020
austinabell
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
#585
Other information and links