Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove incorrectly ported sanity check from go implementation #597

Merged
merged 2 commits into from
Aug 4, 2020
Merged

Remove incorrectly ported sanity check from go implementation #597

merged 2 commits into from
Aug 4, 2020

Conversation

austinabell
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • There is no need for this as these values cannot be nil and was ported over I guess under the assumption it was ensuring the value could not be 0. Should have been a giveaway that value was checked to not be 0.

Reference issue to close (if applicable)

Closes #596

Other information and links

ec2
ec2 approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@ec2 ec2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Exactly what i did to fix it

@austinabell austinabell merged commit d7dcaf6 into main Aug 4, 2020
@austinabell austinabell deleted the austin/vm/sanitycheckrm branch August 4, 2020 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dutterbutter dutterbutter dutterbutter approved these changes

@ec2 ec2 ec2 approved these changes

@ansermino ansermino Awaiting requested review from ansermino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VM check_message is confusing Zero and EmptyInt
3 participants
@austinabell @ec2 @dutterbutter