Reward actor update #619
Merged
Reward actor update #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
ansermino,
dutterbutter and
ec2
as code owners
RajarupanSampanthan
approved these changes
Aug 12, 2020
ec2
approved these changes
Aug 13, 2020
vm/actor/src/builtin/reward/logic.rs
Outdated
| prev_theta: BigInt, | ||
| curr_theta: BigInt, | ||
| ) -> TokenAmount { | ||
| let mut simple_reward = SIMPLE_TOTAL.clone() * &*EXP_LAM_SUB_ONE; |
There was a problem hiding this comment.
Suggested change
| let mut simple_reward = SIMPLE_TOTAL.clone() * &*EXP_LAM_SUB_ONE; | |
| let mut simple_reward = &*SIMPLE_TOTAL * &*EXP_LAM_SUB_ONE; |
There was a problem hiding this comment.
ah, I actually don't fully understand how this works (seems like it would compile to the same thing because the static would have to be reallocated anyway) But I will make this change here and a line below in case it's more optimized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #563
Other information and links