Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix internal send bug, remove message ref from runtime #659

Merged
merged 6 commits into from
Aug 27, 2020
Merged

Fix internal send bug, remove message ref from runtime #659

merged 6 commits into from
Aug 27, 2020

Conversation

austinabell
Copy link
Contributor

@austinabell austinabell commented Aug 27, 2020 •
edited
Loading

Summary of changes
Changes introduced in this pull request:

  • Internal send was not updating the from address of the message for subsequent calls, so some actor validations would fail
  • Removed unsigned message ref from runtime (is unnecessary and will PR into Lotus removing theirs Remove unsigned message pointer from Runtime filecoin-project/lotus#3366)
    • I just wanted to make sure no where referenced the unsigned message data
  • Other small changes to be proactive with inconsistencies

This makes 3 more pass, but 2 fail (previously false positive)
34/66

Reference issue to close (if applicable)

Closes

Other information and links

ec2
ec2 approved these changes Aug 27, 2020
View reviewed changes
Copy link
Member

@ec2 ec2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think you meant to comment that out. Other than that, lgtm

tests/conformance_tests/tests/conformance_runner.rs Outdated
return false;
}
}
// for rx in SKIP_TESTS.iter() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??????

@austinabell austinabell merged commit 5e35560 into main Aug 27, 2020
@austinabell austinabell deleted the austin/sendervm branch August 27, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dutterbutter dutterbutter dutterbutter approved these changes

@ec2 ec2 ec2 approved these changes

@ansermino ansermino Awaiting requested review from ansermino

@RajarupanSampanthan RajarupanSampanthan Awaiting requested review from RajarupanSampanthan

@timvermeulen timvermeulen Awaiting requested review from timvermeulen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@austinabell @ec2 @dutterbutter