-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update blocksync message formats #686
Conversation
blockchain/chain_sync/src/sync.rs
Outdated
// store messages | ||
self.chain_store.put_messages(&b.bls_msgs)?; | ||
self.chain_store.put_messages(&b.secp_msgs)?; | ||
// store messagesc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
blockchain/chain_sync/src/sync.rs
Outdated
// store messages | ||
self.chain_store.put_messages(&b.bls_msgs)?; | ||
self.chain_store.put_messages(&b.secp_msgs)?; | ||
// store messagesc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// store messagesc | |
// store messages |
node/forest_libp2p/src/service.rs
Outdated
@@ -128,8 +128,8 @@ where | |||
warn!("Failed to bootstrap with Kademlia: {}", e); | |||
} | |||
|
|||
let (network_sender_in, network_receiver_in) = channel(20); | |||
let (network_sender_out, network_receiver_out) = channel(20); | |||
let (network_sender_in, network_receiver_in) = channel(200); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too high, no? Or did you try lower and the channels were choking out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh ooops, didn't mean to swap
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links