-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Actors error handling #722
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
ansermino,
dutterbutter and
ec2
as code owners
September 29, 2020 17:12
austinabell
requested review from
timvermeulen,
StaticallyTypedAnxiety and
RajarupanSampanthan
September 29, 2020 17:14
Good stuff! The |
timvermeulen
approved these changes
Oct 1, 2020
dutterbutter
approved these changes
Oct 1, 2020
vm/actor/src/builtin/miner/mod.rs
Outdated
e | ||
e.downcast_default( | ||
ExitCode::ErrIllegalState, | ||
format!("failed to replaces sector expirations at {:?}", key), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional/Nit: 'replace' instead of replaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
ActorError
because ofSysErrOutOfGas
from blockstore interactions within those structures.The only time this can ever be a difference is if the go implementation uses
(ExitCode) Wrapf
orrt.Abort
, an out of gas error was not hit, and there was a different actor error was hit that would be overwritten by this. After checking all usages of this (I could be missing a case and was just skimming, there was ~300 of these as well) I'm semi confident all of them do not fit this criteria, or when they do the go implementation would just fatal error (so it doesn't matter)Reference issue to close (if applicable)
Closes #720
Other information and links