Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update params and fetch on daemon start #733

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Update params and fetch on daemon start #733

merged 1 commit into from
Oct 7, 2020

Conversation

austinabell
Copy link
Contributor

@austinabell austinabell commented Oct 7, 2020 •
edited
Loading

Summary of changes
Changes introduced in this pull request:

  • update params version (oops was still v27, needed to be v28)
  • Avoids bug with HEAD requests in surf
    • I've indicated to maintainers and they are looking into, can link to issue when available
  • Fetches verification keys on daemon start

Reference issue to close (if applicable)

Closes #717

Other information and links

@austinabell austinabell merged commit 0d86e68 into main Oct 7, 2020
@austinabell austinabell deleted the austin/paramupdate branch October 7, 2020 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dutterbutter dutterbutter dutterbutter approved these changes

@RajarupanSampanthan RajarupanSampanthan RajarupanSampanthan approved these changes

@ansermino ansermino Awaiting requested review from ansermino

@ec2 ec2 Awaiting requested review from ec2

@StaticallyTypedAnxiety StaticallyTypedAnxiety Awaiting requested review from StaticallyTypedAnxiety

@timvermeulen timvermeulen Awaiting requested review from timvermeulen

Assignees
No one assigned
Labels
Node
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automatically fetch verification params on daemon start
3 participants
@austinabell @RajarupanSampanthan @dutterbutter