Fix miner constructor params and proving period offset calculation #740
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Bugs:
assign_proving_period_offset
was panicking when writing to the address bytes (because it was attempting to write over the address bytes and would fail if the current length was not enough to write a BE u64 value) so I switched to using the buffer writing variant%
from a unsigned integer, so values were off when calculating period offsetReference issue to close (if applicable)
Closes
Other information and links